ChenSammi commented on code in PR #10203:
URL: https://github.com/apache/ozone/pull/10203#discussion_r3418117604
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/protocol/OzoneManagerProtocol.java:
##########
@@ -252,6 +253,17 @@ default void commitKey(OmKeyArgs args, long clientID)
"this to be implemented, as write requests use a new approach.");
}
+ /**
+ * Commit a key and optionally return the stored modification time (epoch
millis).
+ * <p>
+ * This is backward compatible with older OM versions which do not return
+ * the value in {@code CommitKeyResponse}.
+ */
+ default OptionalLong commitKeyWithModificationTime(OmKeyArgs args, long
clientID) throws IOException {
Review Comment:
It looks like that LastModified element is a mandatory part of CopyObject
and UploadPartCopy.
https://docs.aws.amazon.com/AmazonS3/latest/API/API_CopyObject.html
https://docs.aws.amazon.com/AmazonS3/latest/API/API_UploadPartCopy.html
So without this patch, Ozone returns incorrect LastModified? Since there is
already lastModified field in CopyObjectResponse and CopyPartResult.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
