errose28 commented on code in PR #10523:
URL: https://github.com/apache/ozone/pull/10523#discussion_r3422472882
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/placement/metrics/SCMMetrics.java:
##########
@@ -180,7 +180,6 @@ public void addRatisEvent(String event) {
}
}
- @Metric("Ratis state machine events")
public String getRatisEvents() {
Review Comment:
Let's add a comment here explaining why this should not be exposed with
`@Metric`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]