fmorg-git commented on PR #10203: URL: https://github.com/apache/ozone/pull/10203#issuecomment-4724855116
> > In the latent S3 implementation, the code was doing an additional read on the destination object to get the eTag and modificationTime when the file was created. > > Fabian, Can you point to the code which is doing this? > > > This is problematic, because AWS doesn't require s3:GetObject action on the destination file, so this extra read was causing STS smoke tests to fail > > Can you point out failed smoke test? I removed the code that was doing the additional read on the destination object. Copilot flagged it as an issue in the previous PR as well but had an incorrect suggested fix: https://github.com/apache/ozone/pull/10197#discussion_r3386827556. This series of smoke tests will fail without this fix: https://github.com/fmorg-git/ozone/blob/0ece11555841b68822e0f5a87c77fc4830ec4fda/hadoop-ozone/dist/src/main/smoketest/security/ozone-secure-sts.robot#L927-L984 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
