fmorg-git commented on code in PR #10203:
URL: https://github.com/apache/ozone/pull/10203#discussion_r3425931104
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/protocol/OzoneManagerProtocol.java:
##########
@@ -252,6 +253,17 @@ default void commitKey(OmKeyArgs args, long clientID)
"this to be implemented, as write requests use a new approach.");
}
+ /**
+ * Commit a key and optionally return the stored modification time (epoch
millis).
+ * <p>
+ * This is backward compatible with older OM versions which do not return
+ * the value in {@code CommitKeyResponse}.
+ */
+ default OptionalLong commitKeyWithModificationTime(OmKeyArgs args, long
clientID) throws IOException {
Review Comment:
> Since it's mandatory for S3, we don't need to maintain both
commitKeyWithModificationTime and commitKey, update commitKey to return long,
@ChenSammi - would this be a breaking api change to commitKey for older
clients or mixed client versions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
