Copilot commented on code in PR #10217:
URL: https://github.com/apache/ozone/pull/10217#discussion_r3432632993
##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/service/TestQuotaRepairTask.java:
##########
@@ -47,12 +50,21 @@
import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos;
import org.apache.hadoop.util.Time;
import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.Timeout;
/**
* Test class for quota repair.
*/
+@Timeout(120)
public class TestQuotaRepairTask extends TestOMKeyRequest {
+ /** Seconds; must match {@link Timeout} on this class. */
+ private static final int REPAIR_TEST_TIMEOUT_SECONDS = 120;
Review Comment:
Class-level `@Timeout` value is duplicated in REPAIR_TEST_TIMEOUT_SECONDS
and must be manually kept in sync. Use the constant in the annotation to avoid
mismatches if the timeout is adjusted later.
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/QuotaRepairTask.java:
##########
@@ -72,6 +84,11 @@ public class QuotaRepairTask {
QuotaRepairTask.class);
private static final int BATCH_SIZE = 5000;
private static final int TASK_THREAD_CNT = 3;
+ /**
+ * Parallel full-table scans: OBS keys, FSO files, dirs, active deleted
keys/dirs,
+ * snapshot DB deleted keys/dirs.
+ */
+ private static final int QUOTA_REPAIR_SCAN_TASKS = 6;
Review Comment:
The QUOTA_REPAIR_SCAN_TASKS comment enumerates 7 distinct scans (counting
snapshot DB deleted keys and dirs separately), but the code submits 6
coordinator tasks. Updating the comment to match the actual task breakdown will
avoid confusion when changing thread-pool sizing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
