sodonnel commented on PR #10440: URL: https://github.com/apache/ozone/pull/10440#issuecomment-4741410052
Also this comment from the AI overview: > Extend ReplicationManagerUtil.getTargetDatanodes to validate targets via NodeManager#checkSpaceAndRecordAllocation (PendingContainerTracker-backed) and retry selection when candidates are rejected. Surely when RM asks the placement policy for a node, the node should already have been checked for space? It shouldn't be RMs job to validate free space in a node it just asked for, and then ask for another. The placement policy should do the check and only return "good" nodes (I thought it did that already?) or thrown an error "no possible nodes found". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
