chungen0126 commented on code in PR #10550:
URL: https://github.com/apache/ozone/pull/10550#discussion_r3442913307


##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestSecureOzoneCluster.java:
##########
@@ -541,9 +540,9 @@ void 
testSecureOMDelegationTokenSecretManagerInitializationFailure() throws Exce
       conf.setTimeDuration(OMConfigKeys.DELEGATION_TOKEN_MAX_LIFETIME_KEY, 7, 
TimeUnit.DAYS);
       IllegalArgumentException exception = assertThrows(
           IllegalArgumentException.class, () -> setupOm(conf));
-      assertTrue(exception.getMessage().contains("Secret key expiry duration 
hdds.secret.key.expiry.duration "  +
+      assertThat(exception.getMessage()).contains("Secret key expiry duration 
hdds.secret.key.expiry.duration "  +
           "should be greater than value of 
(ozone.manager.delegation.token.max-lifetime + " +
-          "ozone.manager.delegation.remover.scan.interval + 
hdds.secret.key.rotate.duration"));
+          "ozone.manager.delegation.remover.scan.interval + 
hdds.secret.key.rotate.duration");
     } finally {
       if (scm != null) {
         scm.stop();

Review Comment:
   That makes perfect sense. Let’s defer it to HDDS-12250 to keep this PR 
focused. Thanks for pointing that out and updating the ticket! 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to