adoroszlai commented on PR #10501:
URL: https://github.com/apache/ozone/pull/10501#issuecomment-4761771205
```
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/common/ReadOnlyChunkBuffer.java
23: Wrong lexicographical order for 'java.nio.ReadOnlyBufferException'
import. Should be before 'java.nio.channels.GatheringByteChannel'.
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/BlockOutputStream.java
618: Use Objects.requireNonNull instead of Preconditions.checkNotNull
621: Use Objects.requireNonNull instead of Preconditions.checkNotNull
990: Use Objects.requireNonNull instead of Preconditions.checkNotNull
993: Use Objects.requireNonNull instead of Preconditions.checkNotNull
hadoop-hdds/client/src/test/java/org/apache/hadoop/hdds/scm/storage/TestBlockOutputStreamReferencedWrite.java
33: Wrong lexicographical order for
'java.util.concurrent.CompletableFuture' import. Should be before
'org.apache.hadoop.hdds.protocol.DatanodeDetails'.
34: Wrong lexicographical order for
'java.util.concurrent.atomic.AtomicInteger' import. Should be before
'org.apache.hadoop.hdds.protocol.DatanodeDetails'.
35: Wrong lexicographical order for 'org.apache.commons.lang3.RandomUtils'
import. Should be before 'org.apache.hadoop.hdds.protocol.DatanodeDetails'.
36: Wrong lexicographical order for 'org.apache.hadoop.hdds.client.BlockID'
import. Should be before 'org.apache.hadoop.hdds.protocol.DatanodeDetails'.
46: Wrong lexicographical order for
'org.apache.hadoop.hdds.conf.OzoneConfiguration' import. Should be before
'org.apache.hadoop.hdds.protocol.proto.HddsProtos.ReplicationType'.
344: 'CTOR_DEF' should be separated from previous line.
hadoop-hdds/client/src/test/java/org/apache/hadoop/hdds/scm/storage/BlockOutputStreamWriteBenchmark.java
474: More than 7 parameters (found 8).
```
```
PMD Failure: org.apache.hadoop.hdds.scm.storage.ScalingRow:203
Rule:UnusedPrivateField Priority:3 Avoid unused private fields such as
'nsPerWrite'..
PMD Failure:
org.apache.hadoop.hdds.scm.storage.TestBlockOutputStreamReferencedWrite:244
Rule:UnusedPrivateMethod Priority:3 Avoid unused private methods such as
'createStream(BufferPool, CapturingXceiverClient, boolean)'..
```
```
M D ICAST: Result of integer multiplication cast to long in
org.apache.hadoop.hdds.scm.storage.TestBlockOutputStreamReferencedWrite.createStream(BufferPool,
TestBlockOutputStreamReferencedWrite$CapturingXceiverClient, boolean, int,
int, int, boolean) At TestBlockOutputStreamReferencedWrite.java:[line 274]
M P UPM: Private method
org.apache.hadoop.hdds.scm.storage.TestBlockOutputStreamReferencedWrite.createStream(BufferPool,
TestBlockOutputStreamReferencedWrite$CapturingXceiverClient, boolean) is never
called At TestBlockOutputStreamReferencedWrite.java:[line 246]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
