[
https://issues.apache.org/jira/browse/HDDS-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18090600#comment-18090600
]
Chi-Hsuan Huang commented on HDDS-2562:
---------------------------------------
I just took a look at this, and I think it's safe to close this issue.
The two Sonar instances no longer exist in the current code. They were actually
fixed under later JIRAs:
- The main state-machine loop catch was fixed by HDDS-4024 (`a96553e1`), which
set the interrupt flag without rethrowing as `IOException` (that rethrow is
what broke PR #969 and got it reverted)
- The `initCommandHandlerThread` catch was fixed by HDDS-5434 (`1414bc35`)
- Follow-ups HDDS-4233 (`f3a60dce`), HDDS-6377 (`c6cd84cc`), and HDDS-11082
(`99b481bc`) further tidied the logging/handling
In the current code, every `InterruptedException` catch either re-interrupts
the thread or reacts appropriately, and nothing rethrows as `IOException`, so
the old startup regression can't happen again:
[https://github.com/apache/ozone/blob/5b9265d980beab0f8063b807e7618e611044f2d5/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeStateMachine.java#L373-L408]
The one thing I couldn't verify is whether the original SonarCloud rules are
still listed, since the links in the description point to stale issue IDs. But
from the source side this looks resolved, so *I'd suggest closing it as
Resolved/Duplicate.*
> Handle InterruptedException in DatanodeStateMachine
> ---------------------------------------------------
>
> Key: HDDS-2562
> URL: https://issues.apache.org/jira/browse/HDDS-2562
> Project: Apache Ozone
> Issue Type: Sub-task
> Reporter: Dinesh Chitlangia
> Priority: Major
> Labels: newbie, sonar
>
> Fix 2 instances:
> [https://sonarcloud.io/project/issues?id=hadoop-ozone&issues=AW5md-7fKcVY8lQ4ZsRv&open=AW5md-7fKcVY8lQ4ZsRv]
>
> [https://sonarcloud.io/project/issues?id=hadoop-ozone&issues=AW5md-7fKcVY8lQ4ZsRx&open=AW5md-7fKcVY8lQ4ZsRx]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
