chihsuan commented on code in PR #10578:
URL: https://github.com/apache/ozone/pull/10578#discussion_r3452795684
##########
hadoop-ozone/cli-repair/src/main/java/org/apache/hadoop/ozone/repair/om/FSORepairTool.java:
##########
@@ -321,48 +327,50 @@ private void
markPendingToDeleteObjectsInBucket(OmVolumeArgs volume, OmBucketInf
// Find all deleted directories in this bucket and process their children
String bucketPrefix = OM_KEY_PREFIX + volume.getObjectID() +
OM_KEY_PREFIX + bucket.getObjectID();
- try (TableIterator<String, ? extends Table.KeyValue<String, OmKeyInfo>>
deletedDirIterator =
- deletedDirectoryTable.iterator()) {
- deletedDirIterator.seek(bucketPrefix);
- while (deletedDirIterator.hasNext()) {
- Table.KeyValue<String, OmKeyInfo> deletedDirEntry =
deletedDirIterator.next();
- String deletedDirKey = deletedDirEntry.getKey();
-
- // Only process deleted directories in this bucket
- if (!deletedDirKey.startsWith(bucketPrefix)) {
- break;
- }
+ try (BatchedTempWriter writer = new
BatchedTempWriter(pendingToDeleteTable)) {
Review Comment:
Same as `markReachableObjectsInBucket`: the large diff here is
re-indentation from the try-with-resources wrap. Logic is unchanged apart from
threading the writer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
