errose28 commented on PR #10565: URL: https://github.com/apache/ozone/pull/10565#issuecomment-4771090205
Hi @priyeshkaratha, the container scanner is not designed to repair containers it finds issues with, so I don't think we want to implement this. The `.container` file has other metadata, not just the container state which will be missing in this newly created file, and I think having partial `.container` files floating around the system is more problematic than the original issue. Note that the metadata scanner runs more frequently than the data scanner, so both SCM (which gets the unhealthy ICR and sends the delete) and DN would need to be restarted every time the metadata scanner runs for this container to remain indefinitely. If it doesn't make the code too messy we could clean up the logging by not attempting to update the file if the directory does not exist, but note that this is not a common case so we should not do anything too disruptive to the main code flow to accommodate this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
