sravani-revuri commented on code in PR #10569:
URL: https://github.com/apache/ozone/pull/10569#discussion_r3465348245
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/tracing/TracingUtil.java:
##########
@@ -95,13 +97,51 @@ public static synchronized void reconfigureTracing(
initTracing(serviceName, tracingConfig);
}
+ /**
+ * Drain the BatchSpanProcessor queue without shutting down.
+ * Call from short-lived CLIs before the JVM exits.
+ */
+ public static synchronized void flushTracing() {
+ if (batchSpanProcessor == null) {
+ return;
+ }
+ try {
+ batchSpanProcessor.forceFlush().join(10, TimeUnit.SECONDS);
Review Comment:
The default OpenTelemetry BatchSpanProcessor timeout is 30s for background
workers. After multiple test runs, 10s works well, so that upper bound was
chosen. It also matches the default OTLP exporter timeout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
