peterxcli commented on code in PR #10572:
URL: https://github.com/apache/ozone/pull/10572#discussion_r3466175986
##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/S3ConditionalRequest.java:
##########
@@ -196,6 +196,10 @@ private static Response buildNotModifiedResponse(OzoneKey
key) {
return responseBuilder.build();
}
+ static boolean matchesETag(String headerValue, String currentETag) {
+ return eTagMatches(headerValue, currentETag);
+ }
+
private static boolean eTagMatches(String headerValue, String currentETag) {
Review Comment:
let's just expose the existing func.
```suggestion
static boolean eTagMatches(String headerValue, String currentETag) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
