Russole commented on PR #10461: URL: https://github.com/apache/ozone/pull/10461#issuecomment-4794324828
Thanks @rich7420 for working on this. Overall LGTM. The production fix looks correct to me; I only have two minor, non-blocking test-hardening comments. 1. I agree with the reviewer that the Robot smoke test should explicitly verify the request was actually sent with `Transfer-Encoding: chunked` and without `Content-Length`, so it cannot silently stop covering the regression path. 2. In `checkContent()`, it would also be good to assert the parsed `PartNumber` values in addition to the ETags. For example, checking `1` and `2` would catch a parsing regression where part numbers are dropped or swapped. Both are minor and non-blocking. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
