priyeshkaratha commented on code in PR #10613: URL: https://github.com/apache/ozone/pull/10613#discussion_r3480034187
########## hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/DeletedBlockLogStateManagerImpl.java: ########## Review Comment: @ChenSammi After swap-on-flush, deletingTxIDs.isEmpty() in reinitialize() only checks the new empty set, while an in-progress scanner may still hold a reference to the old set with IDs. Is that intentional because onFlush() always runs and block-deletion scanning is stopped before reinitialize (snapshot install / leader–follower reload)? Is my understanding correct? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
