peterxcli commented on code in PR #10511:
URL: https://github.com/apache/ozone/pull/10511#discussion_r3483970389
##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/S3ConditionalRequest.java:
##########
@@ -288,4 +299,20 @@ String getExpectedETag() {
return parseETag(ifMatch);
}
}
+
+ static final class DeleteCondition {
+ private final String ifMatch;
+
+ private DeleteCondition(String ifMatch) {
+ this.ifMatch = ifMatch;
+ }
Review Comment:
`WriteCondition` follows the same pattern
https://github.com/apache/ozone/blob/0db05b0058f8dc298179d9d75c0b87ab009ef165/hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/S3ConditionalRequest.java#L281-L301
I agree it’d be cleaner to store the parsed eTag directly in the class
instead of re-parsing on every getter call. I’ll address both
`DeleteCondition` and `WriteCondition` together in a follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
