chihsuan opened a new pull request, #10621: URL: https://github.com/apache/ozone/pull/10621
## What changes were proposed in this pull request? `testContainerExclusionWithClosedContainerException` intermittently fails at the datanode assertion (`Expecting empty but was: [<uuid>(null/null)]`). The test asserts that after a `ClosedContainerException` only the closed container is excluded. But under the default `ALL_COMMITTED` watch level, a momentarily-slow follower whose watch-for-commit times out is recorded in the client exclude list — intended slow-node-avoidance behaviour of the configurable `watchType` (HDDS-2887). So an empty datanode set is not an invariant under `ALL_COMMITTED`; the assertion predates the `watchType` config and never accounted for it. The test's subject is container exclusion, which is independent of the watch level. This removes the non-invariant `getDatanodes().isEmpty()` assertion (the container and pipeline assertions stay); watch-level datanode exclusion is already covered by `testDatanodeExclusionWithMajorityCommit`. ## What is the link to the Apache JIRA https://issues.apache.org/jira/browse/HDDS-15605 ## How was this patch tested? `intermittent-test-check` on the fork, `TestFailureHandlingByClient`, `test-name=ALL`, 100 runs: the assertion failure did not recur (0/100). ([run](https://github.com/chihsuan/ozone/actions/runs/28273749692)) The 2/100 `waitForContainerClose` timeouts are the pre-existing HDDS-7878; the 2/100 `testDatanodeExclusionWithMajorityCommit` failures are the known HDDS-13972. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
