ivandika3 commented on code in PR #10573:
URL: https://github.com/apache/ozone/pull/10573#discussion_r3510879837
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/pipeline/Pipeline.java:
##########
@@ -170,6 +178,32 @@ public DatanodeID getSuggestedLeaderId() {
return suggestedLeaderId;
}
+ /**
+ * Return the Pipeline supported StorageTier.
+ *
+ * @return Supported StorageTier
+ */
+ public List<StorageTier> getSupportedStorageTier() {
+ lock.readLock().lock();
+ try {
+ return supportedStorageTier;
+ } finally {
+ lock.readLock().unlock();
+ }
+ }
+
+ /**
+ * Set the storageTier supported by the pipeline.
+ */
+ public void setSupportedStorageTier(List<StorageTier> supportedStorageTier) {
Review Comment:
@xichen01 let's remove this `setSupportedStorageTier` and also the
`updateStorageTier` logic in the node report since as we discovered the
updating storage tiers from the node and pipeline report will cause issues.
One pipeline should only own ONE StorageTier and it should be immutable for
its lifetime. If a set of 3 datanodes have multiple storage volumes (e.g. SSD
and HDD), two pipelines will be created one HDD pipeline and one SSD pipeline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
