sreejasahithi commented on PR #10547: URL: https://github.com/apache/ozone/pull/10547#issuecomment-4896540170
> @sreejasahithi PR changes largely looks good, few comments in code inline and some nits below for better tool reliability: > > 1. Can do a simple sanity check for clusterID between datanode VERSION filesand scm DB clusterId. This will help user to avoid any accidental use of some other cluster SCM DB and avoid large number of invalid orphan container reporting. > 2. We have changed from -`-count` to `--length` option now , so if any existing code may break , may need to rethink from backward compatibility point of view. Thanks for the suggestions. I added a cluster ID check between the DataNode VERSION file and the SCM DB cluster ID on mismatch we print a warning and skip orphan/deleted reporting. For --count, I kept it as a hidden deprecated option for backward compatibility, --length is the new default via ListLimitOptions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
