SaketaChalamchala commented on code in PR #10553:
URL: https://github.com/apache/ozone/pull/10553#discussion_r3532361290
##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java:
##########
@@ -1319,7 +1317,26 @@ public OzoneBucket getBucketDetails(
verifyBucketName(bucketName);
OmBucketInfo bucketInfo =
ozoneManagerClient.getBucketInfo(volumeName, bucketName);
- return OzoneBucket.newBuilder(conf, this)
+ return toOzoneBucket(bucketInfo);
+ }
+
+ @Override
+ public List<OzoneBucket> listBuckets(String volumeName, String bucketPrefix,
+ String prevBucket, int maxListResult,
+ boolean hasSnapshot)
+ throws IOException {
+ List<OmBucketInfo> buckets = ozoneManagerClient.listBuckets(
+ volumeName, prevBucket, bucketPrefix, maxListResult, hasSnapshot);
Review Comment:
Thanks for the review @Gargi-jais11. I updated the PR description.
**listBuckets** is not changed intentionally. Right now, `listBuckets`
prints `OmBucketInfo` for the link buckets which includes link volume, bucket,
name, owner, ACLS and sourceVolume, sourceBucket. It does not print layout,
replication, quotas etc. by design. Since, it does not print any incorrect
values anyway I didn't change it's implementation and it avoids O(links × chain
depth) extra work of resolving links.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
