chihsuan commented on code in PR #10209:
URL: https://github.com/apache/ozone/pull/10209#discussion_r3585989679
##########
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicOzoneFileSystem.java:
##########
@@ -865,6 +866,91 @@ public BlockLocation[] getFileBlockLocations(FileStatus
fileStatus,
}
}
+ @Override
+ public ContentSummary getContentSummary(Path f) throws IOException {
Review Comment:
Agreed that the two implementations have a similar shape and may carry some
maintenance risk.
However, they use different filesystem-specific paths, adapters, listing,
and tracing flows, so extracting a shared helper would broaden this focused
fix. Iād prefer to keep this PR scoped and revisit the duplication if these
implementations need to change again. š
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
