[
https://issues.apache.org/jira/browse/HDDS-11470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18096914#comment-18096914
]
Tsz-wo Sze commented on HDDS-11470:
-----------------------------------
> ... this issue seems being already resolved. ...
[~rich7420], do you mean HDDS-10300 ?
> ... could you double check plz
Checked the code. It seems the problem is still there.
Note that HDDS-10300 only has fixed a particular bug (metadata dir and DB dir
are in different partitions) but not the general problem. If it fails in a
different way, it probably still replies "Completed INSTALL_SNAPSHOT".
> OM should not reply Completed INSTALL_SNAPSHOT when installCheckpoint failed
> ----------------------------------------------------------------------------
>
> Key: HDDS-11470
> URL: https://issues.apache.org/jira/browse/HDDS-11470
> Project: Apache Ozone
> Issue Type: Bug
> Components: OM HA
> Reporter: Tsz-wo Sze
> Priority: Major
>
> When OM failed to installCheckpoint (e.g. HDDS-10300), it should not reply
> "Completed INSTALL_SNAPSHOT".
> In the code below, when there is an exception, it just print an error message
> and continue to reply "Completed INSTALL_SNAPSHOT".
> {code}
> //OzoneManager.installCheckpoint
> try {
> time = Time.monotonicNow();
> dbBackup = replaceOMDBWithCheckpoint(lastAppliedIndex,
> oldDBLocation, checkpointLocation);
> term = checkpointTrxnInfo.getTerm();
> lastAppliedIndex = checkpointTrxnInfo.getTransactionIndex();
> LOG.info("Replaced DB with checkpoint from OM: {}, term: {}, " +
> "index: {}, time: {} ms", leaderId, term, lastAppliedIndex,
> Time.monotonicNow() - time);
> } catch (Exception e) {
> LOG.error("Failed to install Snapshot from {} as OM failed to
> replace" +
> " DB with downloaded checkpoint. Reloading old OM state.",
> leaderId, e);
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
