symious commented on code in PR #10781:
URL: https://github.com/apache/ozone/pull/10781#discussion_r3600097216
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmBucketInfo.java:
##########
@@ -462,6 +478,22 @@ public Builder addAcl(OzoneAcl ozoneAcl) {
public Builder setIsVersionEnabled(boolean versionFlag) {
this.isVersionEnabled = versionFlag;
+ // Keep versioningStatus in sync for callers that only know the legacy
+ // flag; an explicitly SUSPENDED status is preserved on disable.
+ if (versionFlag) {
+ this.versioningStatus = BucketVersioningStatus.ENABLED;
+ } else if (versioningStatus != BucketVersioningStatus.SUSPENDED) {
+ this.versioningStatus = BucketVersioningStatus.UNVERSIONED;
+ }
+ return this;
+ }
+
+ /** No-op when status is null (e.g. records without the new field). */
+ public Builder setVersioningStatus(BucketVersioningStatus status) {
Review Comment:
Nice catch, Updated, PTAL.
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmBucketArgs.java:
##########
@@ -108,6 +114,14 @@ public Boolean getIsVersionEnabled() {
return isVersionEnabled;
}
+ /**
+ * Returns the requested versioning status, or null if not being changed.
+ * @return BucketVersioningStatus
+ */
+ public BucketVersioningStatus getVersioningStatus() {
Review Comment:
Updated, PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
