shuan1026 opened a new pull request, #45:
URL: https://github.com/apache/ozone-helm-charts/pull/45

   ## What changes were proposed in this pull request?
   
   * Adds a Replicas section to `NOTES.txt` so `helm install` / `upgrade` 
prints the configured `om.replicas` and `scm.replicas`.
   * Emits a WARNING when either count is even (Raft quorum is better with odd 
sizes), but does **not** fail the install.
   * Even replica counts remain allowed for OM/SCM migration intermediate 
states (see Jira discussion and RATIS-2296). Odd counts such as 5 are valid and 
are not warned.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-13828
   
   ## How was this patch tested?
   
   * Green CI run
   * Manual verification:
   
   ```bash
   # NOTES are not shown by default with helm template; use dry-run
   helm install ozone charts/ozone --dry-run --debug 2>&1 | tee 
/tmp/notes-default.txt
   grep -nE 'Replicas|om.replicas|scm.replicas|WARNING' /tmp/notes-default.txt
   
   # Even counts should show WARNING
   helm install ozone charts/ozone --dry-run --set om.replicas=2 --set 
scm.replicas=4 2>&1 \
     | grep -E 'WARNING|om.replicas|scm.replicas'
   
   # Odd non-1/3 (e.g. 5) must not fail / must not warn as even
   helm install ozone charts/ozone --dry-run --set om.replicas=5 --set 
scm.replicas=1 2>&1 \
     | grep -E 'WARNING|om\.replicas\)|fail|Replicas'


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to