sreejasahithi opened a new pull request, #10812:
URL: https://github.com/apache/ozone/pull/10812
## What changes were proposed in this pull request?
Currently, Container Balancer could start with configuration that made
balancing impossible or misleading, with no clear reporting to the user.
This change adds startup time validation and ensures configuration errors
are returned to the client with a useful message.
Problem :
Users could start the balancer with invalid or self-defeating configuration,
for example:
- non existent container IDs
- all include-datanodes covered by exclude-datanodes, or all
include-containers covered by exclude-containers
- fewer than two eligible healthy in-service datanodes after applying
include/exclude filters
- max-datanodes-percentage-to-involve-per-iterationthat rounds down to
fewer than two datanodes
- per iteration size limits where max-size-entering-target or
max-size-leaving-source exceeds max-size-moved-max-per- iteration
- max-datanodes-percentage-to-involve-per-iteration set to 0, which cannot
support any balancing iteration
This patch adds validation in ContainerBalancer before the balancer task
starts. Failures throw InvalidContainerBalancerConfigurationException, so ozone
admin containerbalancer start reports the reason to the user.
Note: The datanode check validates that at least two eligible datanodes
exist and that the configured percentage allows at least two datanodes to be
involved per iteration. It does not validate whether those datanodes can
actually form a valid source or target, because that would require reusing much
of the balancer iteration logic. Failures of that kind may still appear via
ozone admin containerbalancer status (stop reason / message).
## What is the link to the Apache JIRA
[HDDS-15535](https://issues.apache.org/jira/browse/HDDS-15535)
## How was this patch tested?
Added tests
Manually tested in docker ozone cluster:
```
bash-5.1$ ozone admin containerbalancer start --include-datanodes
ozone-balancer-datanode1-1.ozone-balancer_default,ozone-balancer-datanode2-1.ozone-balancer_default
--exclude-datanodes
ozone-balancer-datanode2-1.ozone-balancer_default,ozone-balancer-datanode1-1.ozone-balancer_default
-t 0.001
Failed to start Container Balancer. include-datanodes is a subset of
exclude-datanodes, no datanode can participate in balancing.
bash-5.1$
bash-5.1$ ozone admin containerbalancer start --include-containers 1,2,3,4
--exclude-containers 1,2,3,4 -t 0.001
Failed to start Container Balancer. include-containers is a subset of
exclude-containers, no container can be selected for balancing.
bash-5.1$
bash-5.1$ ozone admin containerbalancer start
--max-datanodes-percentage-to-involve-per-iteration 20 -t 0.001
Failed to start Container Balancer.
max-datanodes-percentage-to-involve-per-iteration=20 allows at most 1
datanode(s) per iteration with 6 eligible datanode(s), but at least 2 are
required for a source and target datanode pair.
bash-5.1$
bash-5.1$ ozone admin containerbalancer start
--max-datanodes-percentage-to-involve-per-iteration 0 -t 0.001
Max Datanodes Percentage To Involve Per Iteration must be greater than zero.
bash-5.1$
```
Green CI : https://github.com/sreejasahithi/ozone/actions/runs/29627948987
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
