rich7420 commented on code in PR #10814:
URL: https://github.com/apache/ozone/pull/10814#discussion_r3618753234
##########
hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/endpoint/TestBucketPut.java:
##########
@@ -35,25 +38,37 @@
*/
public class TestBucketPut {
+ private static final String OTHER_BUCKET_OWNER = "other-s3-owner";
+
private String bucketName = OzoneConsts.BUCKET;
private BucketEndpoint bucketEndpoint;
+ private OzoneClient clientStub;
@BeforeEach
public void setup() throws Exception {
- OzoneClient clientStub = new OzoneClientStub();
+ clientStub = new OzoneClientStub();
bucketEndpoint = EndpointBuilder.newBucketEndpointBuilder()
.setClient(clientStub)
.build();
}
@Test
- public void testCreateBucketAndFailOnDuplicate() throws Exception {
+ public void testCreateBucketAndFailOnDuplicateWithSameOWNER() throws
Exception {
Review Comment:
Nice work on this! Small non-blocking note: the same-owner case here passes
via `null == null` (the stub bucket has no owner and no principal is set), so
it doesn't quite exercise a real owner match. Setting a principal and a
matching bucket owner would cover `getRequestOwner()`. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
