szetszwo commented on code in PR #10633: URL: https://github.com/apache/ozone/pull/10633#discussion_r3623861478
########## hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java: ########## Review Comment: It is better to return null, since checking `sortedNodes != nodes` look like a bug -- people may change it to use `equals(..)` later on. ########## hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java: ########## Review Comment: It is better to return null, since checking `sortedNodes != nodes` looks like a bug -- people may change it to use `equals(..)` later on. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
