devmadhuu commented on PR #10810: URL: https://github.com/apache/ozone/pull/10810#issuecomment-5036834985
> > Thanks @xichen01 for your suggestions, but for community development, we usually follow the feature branch approach where [Feature branch HDDS-11233](https://github.com/apache/ozone/tree/HDDS-11233) seems appropriate for further developments post this [last PR](https://github.com/apache/ozone/pull/10810#10573) in this branch. So if this feature has already been fully implemented in your branch, could you kindly raise follow up PRs in [Feature branch HDDS-11233](https://github.com/apache/ozone/tree/HDDS-11233), so that any remaining impacts and other pending items can be picked up after we test impact on other features before the feature finally lands up on master. > > Thanks @devmadhuu for the clarification. > > The [HDDS-11233](https://issues.apache.org/jira/browse/HDDS-11233) previous PRs were already created by cherry-picking our internal commits in the same order and adapting them to the community branch. > > Our concern is that the current implementation for this ticket differs from our internal version. This would make the following commits (cherry-pick) difficult to reuse through cherry-picking and require substantial rework, even though the final result may be similar. > > Would it be possible to align this implementation more closely with the branch we shared, while still submitting the PR to `HDDS-11233`? Thanks @xichen01 for your suggestions. Based on your shared [storage tier commits tar gz](https://issues.apache.org/jira/secure/attachment/13077025/storage-policy-diff.tar.gz ) and as discussed with @ChenSammi , I understand that diff #10, #11 and #12 can be first raised in order and I have raised for #10 (SCM Pipeline Support Create And Get With StorageTier) from your tar in community [upstream branch ](https://github.com/apache/ozone/tree/HDDS-11233). Since your patch for #10 was based on old checkout version, since then code is deviated and updated lot, hence I had to adapt your changes for #10 as per current upstream branch. I request you to have a look once , so that I can raise for others from your tar gz. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
