jojochuang commented on code in PR #10745:
URL: https://github.com/apache/ozone/pull/10745#discussion_r3626941393
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java:
##########
@@ -2993,8 +2993,17 @@ public List<OmBucketInfo> listBuckets(String volumeName,
String startKey,
volumeName, null, null);
}
metrics.incNumBucketLists();
- return bucketManager.listBuckets(volumeName,
+ List<OmBucketInfo> buckets = bucketManager.listBuckets(volumeName,
startKey, prefix, maxNumOfBuckets, hasSnapshot);
+ Map<Pair<String, String>, OmBucketInfo> resolvedSourceCache = new
HashMap<>();
+ for (int i = 0; i < buckets.size(); i++) {
+ try {
+ buckets.set(i, enrichLinkBucketInfo(buckets.get(i),
resolvedSourceCache));
+ } catch (IOException e) {
+ // Keep the raw bucket entry if source resolution fails.
+ }
+ }
Review Comment:
yeah we need this.
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmBucketInfo.java:
##########
@@ -396,6 +396,31 @@ public Builder toBuilder() {
.setTags(tags);
}
+ /**
+ * Returns a copy of this bucket with operational properties taken from
+ * {@code source}. Link identity fields (volume, name, owner, source path,
+ * ACLs, timestamps, object/update IDs) are unchanged.
+ *
+ * <p>When adding new operational bucket fields, update this method if they
+ * should be resolved from a link's source bucket.
+ */
+ public OmBucketInfo withOperationalPropertiesFrom(OmBucketInfo source) {
Review Comment:
this is good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
