echonesis commented on PR #10819: URL: https://github.com/apache/ozone/pull/10819#issuecomment-5060690486
Thanks @chihsuan for the review. I tested the 3s/6s intervals together with restarting the V2 datanode locally. The runtime increased to about 121 seconds, which removes most of the intended speedup. There are roughly six datanode restarts across the V2 and V3 invocations. Since `restartHddsDatanode` waits for SCM to stop considering the datanode healthy, increasing the stale interval from 1s to 3s raises the minimum stale wait from about 6 seconds total to about 18 seconds total. Restarting V2 also adds three restarts that the in-place restore previously avoided, plus their shutdown, startup, heartbeat, and pipeline recovery costs. To preserve the purpose of this change, I propose keeping the safer 3s/6s intervals but restoring V2 in place. I’ll add a comment explicitly documenting that the V2 volume intentionally remains in failedVolumeMap, that subsequent tests use the restored active volume, and that the cluster is closed after the parameterized invocation. V3 will continue to restart because its shared DB is closed after a volume failure. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
