Copilot commented on code in PR #10792:
URL: https://github.com/apache/ozone/pull/10792#discussion_r3641905912
##########
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneClientAdapterImpl.java:
##########
@@ -690,19 +696,24 @@ public FileStatusAdapter getFileStatus(String path, URI
uri,
* Return FileStatusAdapter based on OFSPath being a
* valid bucket path or valid snapshot path.
* Throws exception in case of failure.
+ *
+ * <p>Non-snapshot paths call OM GetFileStatus directly (HDDS-15925) without
a
+ * prior InfoBucket RPC. OBJECT_STORE buckets are not rejected on this path;
+ * mutating OFS operations still validate layout via {@link
#getBucket(OFSPath, boolean)}.
Review Comment:
The updated Javadoc around getFileStatusForKeyOrSnapshot() is potentially
misleading: it states that "Non-snapshot paths" avoid InfoBucket and implies
layout validation is only done for mutating operations, but listStatus() (a
read operation) still calls getBucket() and enforces layout validation. Also,
the PR description says OBJECT_STORE rejection is unchanged, while this method
comment suggests otherwise. Consider tightening the wording to explicitly scope
the optimization to key paths and to describe how OBJECT_STORE/layout
validation is handled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
