chihsuan commented on code in PR #10861:
URL: https://github.com/apache/ozone/pull/10861#discussion_r3649093598
##########
hadoop-hdds/erasurecode/src/test/java/org/apache/ozone/erasurecode/TestCodecRegistry.java:
##########
@@ -158,4 +158,20 @@ public void testGetCoderByName() {
NativeXORRawErasureCoderFactory.CODER_NAME);
assertInstanceOf(NativeXORRawErasureCoderFactory.class, coder);
}
+
+ @Test
+ public void testRegistryLoadsWithoutTccl() {
Review Comment:
`CodecRegistry.instance` is a static singleton, so if any other test in this
class runs first, the registry is already initialized, and this test passes
even with the fix reverted.
https://github.com/apache/ozone/blob/d38e83979ff857dcf6a68c47403613151b0d5a26/hadoop-hdds/erasurecode/src/main/java/org/apache/ozone/erasurecode/CodecRegistry.java#L46
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
