AdyChechani commented on code in PR #10831:
URL: https://github.com/apache/ozone/pull/10831#discussion_r3668433984
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMRatisServerImpl.java:
##########
@@ -289,13 +289,24 @@ public List<String> getRatisRoles() {
LOG.error("SCM Ratis PeerInetAddress {} is unresolvable",
peer.getAddress());
}
- ratisRoles.add((peer.getAddress() == null ? "" :
- peer.getAddress().concat(peer.equals(leader) ?
- ":".concat(RaftProtos.RaftPeerRole.LEADER.toString()) :
- ":".concat(RaftProtos.RaftPeerRole.FOLLOWER.toString()))
- .concat(":".concat(peer.getId().toString()))
- .concat(":".concat(peerInetAddress == null ? "" :
- peerInetAddress.getHostAddress()))));
+ if (peer.getAddress() == null) {
+ ratisRoles.add("");
+ continue;
+ }
+ String host = HddsUtils.getHostName(peer.getAddress()).orElse("");
+ int port = HddsUtils.getHostPort(peer.getAddress()).orElse(0);
Review Comment:
Every Ratis peer address is set via `RatisPeer.newBuilder().setAddress()`,
so in practice, a peer always has a port. But I see this can cause confusion.
So, to address this, it now logs an error and skips the peer entry entirely,
rather than silently defaulting to port 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
