jojochuang commented on PR #10913: URL: https://github.com/apache/ozone/pull/10913#issuecomment-5169869473
Thanks for the PR. On the "do we already have DN space utilization?" question: **the underlying data yes, this JMX shape no.** - **Per-volume on the DN:** `VolumeInfoMetrics-<path>` already exposes `OzoneCapacity` / `OzoneUsed` per HDDS data volume. - **Per-DN at cluster scope:** SCM and Recon already aggregate the same heartbeat storage reports (`SCMNodeStat`, Recon `NodeEndpoint`). What's new here is a **single node-level JMX endpoint on the datanode** so operators can scrape one bean instead of summing all volume MBeans or going through SCM/Recon. Reusing `volumeSet.getStorageReport()` is the right source — same numbers we already send upstream. Two small additions beyond the existing review threads: 1. **PR description:** "no metrics available" is a bit strong — per-volume DN JMX and SCM/Recon per-DN stats already exist. Worth reframing as "no *node-level aggregated* DN JMX metric." 2. **Scope:** please call out in the class javadoc that this totals **data volumes only** (same scope as `OzoneContainer.getNodeReport()` storage reports), not meta/DB volumes. That'll avoid surprises for multi-volume DN setups. Conceptually this looks fine to me — a small monitoring convenience, not new storage accounting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
