smengcl commented on code in PR #10950:
URL: https://github.com/apache/ozone/pull/10950#discussion_r3716181826
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/ReconTaskControllerImpl.java:
##########
@@ -882,6 +890,14 @@ private void cleanupPreExistingCheckpoints() {
return;
}
+ // The DB store is only initialized after Recon downloads its first DB
+ // snapshot from the OM. On a fresh startup it may still be null.
+ if (currentOMMetadataManager.getStore() == null) {
+ LOG.debug("OM metadata manager DB store not yet initialized, "
+ + "skipping pre-existing checkpoint cleanup");
+ return;
+ }
Review Comment:
The condition above already returns when `getStore()` is null. This new
condition won't run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
