Copilot commented on code in PR #10953:
URL: https://github.com/apache/ozone/pull/10953#discussion_r3740059907
##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/ratis/TestOzoneManagerStateMachine.java:
##########
@@ -620,12 +620,10 @@ public void testTakeSnapshotAlreadyCaughtUp() throws
Exception {
assertTermIndex(1, 1, sm.getLastAppliedTermIndex());
OMMetadataManager metaMgr = mock(OMMetadataManager.class);
- @SuppressWarnings("unchecked")
- Table<String, TransactionInfo> txnTable = mock(Table.class);
DBStore store = mock(DBStore.class);
when(om.getMetadataManager()).thenReturn(metaMgr);
- when(metaMgr.getTransactionInfoTable()).thenReturn(txnTable);
when(metaMgr.getStore()).thenReturn(store);
+ stubPersistIfNewerAsAccepting();
Review Comment:
Removing the mocked transaction table leaves
`org.apache.hadoop.hdds.utils.db.Table` imported at line 50 with no remaining
use. Ozone enables Checkstyle's `UnusedImports` check
(`hadoop-hdds/dev-support/checkstyle/checkstyle.xml:124`), so this file will
fail checkstyle until that import is removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
