F64116045 commented on code in PR #10963:
URL: https://github.com/apache/ozone/pull/10963#discussion_r3741040439
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/upgrade/TestScmFinalization.java:
##########
@@ -231,8 +233,19 @@ public void testResumeFinalizationFromCheckpoint(
// Execute upgrade finalization, then check that events happened in the
// correct order.
- StatusAndMessages status =
- manager.finalizeUpgrade(UUID.randomUUID().toString());
+ LogCapturer logCapturer =
Review Comment:
Thanks @chihsuan for reviewing.
> What do you think about adding a failure-path test for
removeFinalizingMark()?
I think this makes sense. Added a test for this. Thanks for the suggestion!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
