sreejasahithi commented on code in PR #10938: URL: https://github.com/apache/ozone/pull/10938#discussion_r3751685263
########## hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerMoveFailureTracker.java: ########## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hdds.scm.container.balancer; + +import java.util.ArrayList; +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import org.apache.hadoop.hdds.protocol.DatanodeDetails; +import org.apache.hadoop.hdds.scm.container.ContainerID; + +/** + * Tracks per-iteration container move failures by reason and optional details. + */ +public final class ContainerMoveFailureTracker { + public static final int DEFAULT_MAX_FAILURE_DETAILS = 100; + public static final int DEFAULT_MAX_FAILURE_DETAILS_PER_REASON = 10; + + private final int maxFailureDetails; + private final int maxFailureDetailsPerReason; + private final Map<String, Long> failuresByReason = new HashMap<>(); Review Comment: We already use enums at the call sites i.e MoveManager.MoveResult for what MoveManager.move() returns and ContainerBalancerTask.ContainerMoveFailureReason for before/during move setup, or iteration wait timeout. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
