smengcl commented on PR #10350: URL: https://github.com/apache/ozone/pull/10350#issuecomment-5274903862
> ### Suggestion > Consider an `@implNote` on `computeChecksum(ChunkBuffer)` (and/or a debug assert that walked bytes `== data.remaining()`) so future callers do not pass a partially written multi-buffer without `flip()`/`duplicate()` first. > > Tests (`TestChecksumMultiBuffer`, growing/positioned multi-buffer cache tests) validate the read-ready case well; they do not exercise live write-layout incremental buffers, which production avoids anyway. @jojochuang Let me raise an addendum for the tests and javadoc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
