ChenSammi commented on code in PR #10982:
URL: https://github.com/apache/ozone/pull/10982#discussion_r3775243590
##########
hadoop-hdds/common/src/main/resources/ozone-default.xml:
##########
@@ -1546,9 +1546,19 @@
<value>30d</value>
<tag>OZONE, OM, PERFORMANCE</tag>
<description>
- Controls how long multipart upload is considered active. Specifically,
if a multipart info
- has been ongoing longer than the value of this config entry, that
multipart info is considered as
- expired (e.g. due to client crash). Unit could be defined with postfix
(ns,ms,s,m,h,d)
+ Controls how long a multipart upload is considered active before
MultipartUploadCleanupService
+ treats it as stale and aborts it. If a multipart upload has been ongoing
longer than this
+ threshold (e.g. due to a client crash), it will be cleaned up
automatically.
+ Unit can be specified with a postfix (ns, ms, s, m, h, d).
+
+ Interaction with S3 lifecycle AbortIncompleteMultipartUpload rules:
+ When a bucket lifecycle rule specifies an AbortIncompleteMultipartUpload
action, its
+ daysAfterInitiation value must be strictly not greater than this
threshold (in days). If
Review Comment:
Let's change the "not greater than" back to "less than".
What I'm actually suggest previously, if equality is allowed or not,
daysAfterInitiation is 30 days, and `ozone.om.open.mpu.expire.threshold` is 30
days. Do you think we should allow the equality? Or not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
