greenwich commented on code in PR #10946:
URL: https://github.com/apache/ozone/pull/10946#discussion_r3781667661


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java:
##########
@@ -729,6 +733,10 @@ private OzoneManager(OzoneConfiguration conf, 
StartupOption startupOption)
     omClientProtocolMetrics = ProtocolMessageMetrics
         .create("OmClientProtocol", "Ozone Manager RPC endpoint",
             OzoneManagerProtocolProtos.Type.class);
+    String configuredStoragePolicy = conf.get(
+        OZONE_DEFAULT_STORAGE_POLICY_KEY, 
OZONE_DEFAULT_STORAGE_POLICY_DEFAULT);
+    OzoneStoragePolicy.setDefaultPolicy(OzoneStoragePolicy.valueOf(

Review Comment:
   Ok thanks. `ScmBlockLocationProtocolClientSideTranslatorPB#allocateBlock` 
never sets `storagePolicy`/`allowFallBack` on the request builder, so 
`hasStoragePolicy()` is always false and every allocation falls back to the 
default — I guess it is the plumbing coming in a later patch.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to