fmorg-git commented on PR #11019: URL: https://github.com/apache/ozone/pull/11019#issuecomment-5306811601
> Thanks for the patch! @fmorg-git The `AccessDenied` translation looks correct. > > I left a few inline comments, mostly around the cases the new handling doesn't cover yet and the audit record on the throw path. > > Also, could we add a unit test alongside the smoke test? `TestPermissionCheck#testDeleteKeys` already has the mocks needed. Updated to add unit tests - fc80f776333ee1ffde301a47fc7b748e1fb1e892 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
