aryangupta1998 commented on code in PR #11021:
URL: https://github.com/apache/ozone/pull/11021#discussion_r3801823934
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/KeyLifecycleService.java:
##########
@@ -1617,9 +1628,11 @@ public OzoneManagerProtocolProtos.OMResponse run()
throws Exception {
}
} catch (IOException | InterruptedException e) {
LOG.error("Failed to send RenameKeysRequest", e);
+ failedMoves++;
}
}
keysList.clear();
+ return failedMoves;
Review Comment:
Agreed on the retry-loop concern in combination with rollback. The main
trigger was that already-moved entries were re-seen and then counted as
failures via KEY_NOT_FOUND.
This is now fixed by classifying those missing-source cases as idempotent
success, so they don’t keep failedMoves non-zero on the next pass.
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/KeyLifecycleService.java:
##########
@@ -1617,9 +1628,11 @@ public OzoneManagerProtocolProtos.OMResponse run()
throws Exception {
}
} catch (IOException | InterruptedException e) {
LOG.error("Failed to send RenameKeysRequest", e);
+ failedMoves++;
Review Comment:
Yes, your understanding was correct for the previous code: all rename
failures were counted the same.
I changed it so only real failures increment failedMoves; missing-source
outcomes are skipped as idempotent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
