echonesis opened a new pull request, #11070: URL: https://github.com/apache/ozone/pull/11070
## What changes were proposed in this pull request? `StorageContainerLocationProtocol` is an internal Java interface, while Hadoop RPC uses `StorageContainerLocationProtocolPB`, which extends the generated protobuf service interface. Both interfaces previously defined the protocol version and Kerberos metadata. However, the RPC server registration, client proxy, and failover provider use `StorageContainerLocationProtocolPB`, so the metadata on `StorageContainerLocationProtocol` was redundant and could incorrectly imply that this Java interface defines the wire protocol. This PR: - Removes `versionID` and `@KerberosInfo` from `StorageContainerLocationProtocol`. - Keeps the interface, its FQCN, methods, PB interface, translators, protobuf definitions, and `SCMPolicyProvider` unchanged. - Adds a focused test confirming that the historical protocol name, protocol version, and Kerberos metadata are provided by `StorageContainerLocationProtocolPB`. The historical FQCN is preserved because it remains the protocol name declared by `StorageContainerLocationProtocolPB` and is used by service authorization through `SCMPolicyProvider`. This change does not modify the protobuf service or Hadoop RPC protocol identity, so the wire protocol remains unchanged. ## What is the link to the Apache JIRA https://issues.apache.org/jira/browse/HDDS-16192 ## How was this patch tested? Local Test ```shell mvn -pl :hdds-server-framework -am test \ -Dtest=TestStorageContainerLocationProtocolPB \ -Dsurefire.failIfNoSpecifiedTests=false \ -DskipShade -DskipRecon -DskipDocs mvn -pl :ozone-integration-test test \ -Dtest=TestSecureOzoneCluster#testSecureScmAndOmStartupAndAccessControl \ -DskipShade -DskipRecon ``` GitHub Actions CI: https://github.com/echonesis/ozone/actions/runs/32326358698 Generated-by: Codex (GPT-5) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
