ChenSammi commented on code in PR #11021:
URL: https://github.com/apache/ozone/pull/11021#discussion_r3820696469
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/KeyLifecycleService.java:
##########
@@ -1547,8 +1547,10 @@ private void moveToTrash(OmBucketInfo bucket,
LimitedExpiredObjectList keysList,
try {
checkAndCreateTrashDirIfNeeded(bucket, trashCurrent);
} catch (IOException e) {
- keysList.clear();
- return;
+ String message =
Review Comment:
@aryangupta1998 , thanks for updating the patch. The change looks good to
me.
Could you add a unit test for the fail to create trash root case? to make
sure the exception will be bumped up to task level, and abort the task?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
