chihsuan commented on code in PR #11048:
URL: https://github.com/apache/ozone/pull/11048#discussion_r3822569333
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/container/TestContainerStateManagerIntegration.java:
##########
@@ -244,12 +245,12 @@ public void testGetMatchingContainerMultipleThreads()
return null;
}, executor);
}
+ CompletableFuture.allOf(futures).join();
Review Comment:
Could this use a bounded `get(timeout, TimeUnit)`? `join()` introduces an
unbounded, non-interruptible wait over 100,000 tasks, so a stuck task may hold
the test until the Surefire fork timeout.
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/container/TestContainerStateManagerIntegration.java:
##########
@@ -224,7 +224,7 @@ public void testGetMatchingContainer() throws IOException {
@Test
@Flaky("HDDS-1159")
Review Comment:
This annotation `@Flaky` still excludes the test from regular CI. Should we
remove it and its unused import?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
