chihsuan commented on code in PR #11018:
URL: https://github.com/apache/ozone/pull/11018#discussion_r3829326431
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmKeyInfo.java:
##########
@@ -74,6 +74,11 @@ public final class OmKeyInfo extends WithParentObjectId
// name of key client specified
private String keyName;
private long dataSize;
+ /**
+ * Block locations of the key, one group per key version. No write path
produces more than one group today, so a
+ * key holds a single version and {@code dataSize} covers all of its blocks.
Object versioning (HDDS-15728) keeps
+ * each object version in its own OmKeyInfo rather than adding groups here.
+ */
private List<OmKeyLocationInfoGroup> keyLocationVersions;
Review Comment:
Thanks for the review! @smengcl
You're right, the wording rules out a case
`testOverWriteKeyWithAndWithOutVersioning` actually reaches, so it does need to
change. I'll reword it to describe the versioned-bucket case rather than deny
it.
On handling multiple groups, I'd like to check with you before going that
way. Fixing the active-table recount on its own would still leave
`snapshotUsedBytes` collapsing (HDDS-16184) and leave repair and delete
disagreeing on the same key (HDDS-16178), and the EC formula question in
HDDS-16176 may well change the conversion again, so it seems to grow into a set
of four rather than a single fix. Since no write path exercises versioning
today, I leaned toward documenting it accurately for now, but I'm happy to take
on the whole set if you feel it's worth doing properly. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
