echonesis commented on PR #11067: URL: https://github.com/apache/ozone/pull/11067#issuecomment-5393088957
> Thanks @echonesis for working on this. > > However, I have a minor suggestion regarding the class hierarchy. Having O3DtFetcher and OfsDtFetcher extend O3fsDtFetcher feels semantically incorrect, as they are parallel schemes rather than a parent-child relationship. Good point, thanks @chungen0126 for the suggestion. I refactored the shared token-fetching logic into a package-private AbstractOzoneDtFetcher. O3fsDtFetcher, OfsDtFetcher, and O3DtFetcher now extend this common base class as sibling scheme providers. Their existing behavior and ServiceLoader registrations remain unchanged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
