jojochuang commented on code in PR #11068:
URL: https://github.com/apache/ozone/pull/11068#discussion_r3866269545
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/TypedTable.java:
##########
@@ -228,6 +230,15 @@ public VALUE getSkipCache(KEY key) throws
RocksDatabaseException, CodecException
return getFromTable(key);
}
+ @Override
+ public List<VALUE> multiGetSkipCache(List<KEY> keys)
+ throws RocksDatabaseException, CodecException {
+ if (keys.isEmpty()) {
Review Comment:
Suggest to guard against null keys to be consistent with
Table.multiGetSkipCache()
```suggestion
if (keys == null || keys.isEmpty()) {
```
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/TypedTable.java:
##########
@@ -306,6 +317,114 @@ private VALUE getFromTable(KEY key) throws
RocksDatabaseException, CodecExceptio
}
}
+ List<VALUE> multiGetFromTable(List<KEY> keys)
+ throws RocksDatabaseException, CodecException {
+ if (supportCodecBuffer) {
Review Comment:
i would refactor here to make it more readable. Too much things happen in
this method.
##########
hadoop-hdds/framework/src/test/java/org/apache/hadoop/hdds/utils/db/InMemoryTestTable.java:
##########
@@ -75,6 +76,18 @@ public VALUE get(KEY key) {
return map.get(key);
}
+ @Override
+ public List<VALUE> multiGetSkipCache(List<KEY> keys) {
+ if (keys.isEmpty()) {
Review Comment:
```suggestion
if (keys == null || keys.isEmpty()) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
