Copilot commented on code in PR #11135:
URL: https://github.com/apache/ozone/pull/11135#discussion_r3877573834
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/multipart/S3MultipartUploadCompleteRequest.java:
##########
@@ -341,6 +341,11 @@ public OMClientResponse
validateAndUpdateCache(OzoneManager ozoneManager, Execut
if (keyToDelete != null && !omBucketInfo.getIsVersionEnabled()) {
RepeatedOmKeyInfo oldKeyVersionsToDelete = getOldVersionsToCleanUp(
keyToDelete, omBucketInfo.getObjectID(), trxnLogIndex);
+ // Remove any block from oldKeyVersionsToDelete that shares the same
+ // container ID and local ID with omKeyInfo blocks'.
+ // Otherwise, it causes data loss once those shared blocks are added
+ // to deletedTable and processed by KeyDeletingService for deletion.
Review Comment:
The new comment has a grammatical issue ("omKeyInfo blocks'") and is a bit
unclear about what is being compared. Rewording it to explicitly mention
ContainerBlockID (containerID + localID) would improve readability and avoid
the stray apostrophe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
